Skip to content

NE-1324: Name change for ExternalDNS Shared VPC E2E#44311

Merged
openshift-ci[bot] merged 1 commit into
openshift:masterfrom
gcs278:sharedvpc-e2e-package-update
Oct 27, 2023
Merged

NE-1324: Name change for ExternalDNS Shared VPC E2E#44311
openshift-ci[bot] merged 1 commit into
openshift:masterfrom
gcs278:sharedvpc-e2e-package-update

Conversation

@gcs278

@gcs278 gcs278 commented Oct 12, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

As the shared VPC E2E tests have been moved to a dedicated testing package, modify the shared VPC E2E test to reference this new package.

Epic: NE-1324

Previous PR: #42894
Implementation PR: openshift/external-dns-operator#198

@gcs278
NE-1324: Name change for ExternalDNS Shared VPC E2E
c78ab41 
As the shared VPC E2E tests have been moved to a dedicated testing
package, modify the shared VPC E2E test to reference this new package.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 12, 2023
@openshift-ci-robot

openshift-ci-robot commented Oct 12, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

@gcs278: This pull request references NE-1324 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

As the shared VPC E2E tests have been moved to a dedicated testing package, modify the shared VPC E2E test to reference this new package.

Epic: NE-1324

Previous PR: #42894
Implementation PR: openshift/external-dns-operator#198

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot

openshift-ci-robot commented Oct 12, 2023 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Contributor

@gcs278: This pull request references NE-1324 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

As the shared VPC E2E tests have been moved to a dedicated testing package, modify the shared VPC E2E test to reference this new package.

Epic: NE-1324

Previous PR: #42894
Implementation PR: openshift/external-dns-operator#198

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278

gcs278 commented Oct 12, 2023

Copy link
Copy Markdown
Contributor Author

/hold
Wait for openshift/external-dns-operator#198 to be merged; otherwise, CI will be broken.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@openshift-ci
openshift-ci Bot requested review from lmzuccarelli and miheer October 12, 2023 18:29
@openshift-ci-robot

openshift-ci-robot commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@gcs278: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator openshift/external-dns-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@alebedev87

alebedev87 commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci

openshift-ci Bot commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, gcs278

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@gcs278

gcs278 commented Oct 26, 2023

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator

@gcs278

gcs278 commented Oct 26, 2023

Copy link
Copy Markdown
Contributor Author

/pj-rehearse abort
openshift/external-dns-operator#198 needs to merge before testing

@gcs278

gcs278 commented Oct 27, 2023

Copy link
Copy Markdown
Contributor Author

openshift/external-dns-operator#198 merged

/pj-rehearse pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator

@gcs278

gcs278 commented Oct 27, 2023

Copy link
Copy Markdown
Contributor Author

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/44311/rehearse-44311-pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator/1717730158892290048 LGTM.

/pj-rehearse ack
/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 27, 2023
@gcs278

gcs278 commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ehh, one more run wouldn't hurt.
/hold
/pj-rehearse pull-ci-openshift-external-dns-operator-main-e2e-aws-shared-vpc-phz-operator

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2023
@gcs278

gcs278 commented Oct 27, 2023

Copy link
Copy Markdown
Contributor Author

Two clean runs.
/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2023
@openshift-ci

openshift-ci Bot commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
openshift-ci Bot merged commit 62f20c3 into openshift:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmzuccarelli lmzuccarelli Awaiting requested review from lmzuccarelli
@miheer miheer Awaiting requested review from miheer

Assignees

@alebedev87 alebedev87

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gcs278 @openshift-ci-robot @alebedev87